PLAT-623 sync/async receiver openhim import #180
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mark-Labuschagne
changed the base branch from
main
to
PLAT-620-add-jempi-services
Contributor
Author
|
@rcrichton please have a look at the url patterns for the sync/async receivers - I don't know what they're actually supposed to be. |
nour-borgi
reviewed
Nov 29, 2022
Co-authored-by: Nour Borgi <48720958+nour-borgi@users.noreply.github.com>
Co-authored-by: Nour Borgi <48720958+nour-borgi@users.noreply.github.com>
the defaults there would never be accessed, and should always have set values in their docker-compose files PLAT-623
nour-borgi
approved these changes
Nov 29, 2022
nour-borgi
reviewed
Nov 29, 2022
rcrichton
suggested changes
Nov 30, 2022
Contributor
rcrichton
left a comment
rcrichton
left a comment
There was a problem hiding this comment.
LGTM, just on comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.