-
Notifications
You must be signed in to change notification settings - Fork 9
Grafana/Loki connectivity and Bitnami image migration #342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Update all Bitnami Docker image references to use the new bitnamilegacy repository following the Bitnami community catalog migration. Changes: - database-postgres: Updated postgresql-repmgr and pgpool images - identity-access-manager-keycloak: Updated postgresql-repmgr image - client-registry-jempi: Updated postgresql-repmgr image - client-registry-santempi: Updated postgresql-repmgr image - message-bus-kafka: Updated kafka image All image references changed from bitnami/ to bitnamilegacy/
WalkthroughEnvironment variables referencing Docker images across multiple service configurations were updated from Bitnami to Bitnamilegacy registry versions. Additionally, a network configuration was added to a monitoring service. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@message-bus-kafka/package-metadata.json`:
- Line 9: The KAFKA_IMAGE metadata entry currently points to the unmaintained
legacy image "bitnamilegacy/kafka:3.4.0"; update the value of the KAFKA_IMAGE
key to use the supported Bitnami image (e.g., "bitnami/kafka:3.4.0" or a newer
supported tag) or, if you must keep that exact legacy image, document and
replace it with a mirrored image in your own registry; edit the
package-metadata.json KAFKA_IMAGE entry to one of these supported options and
ensure any deployment manifests referencing KAFKA_IMAGE use the new value.
🧹 Nitpick comments (2)
identity-access-manager-keycloak/package-metadata.json (1)
9-9: Consider pinning the image with a SHA digest for reproducibility.The migration to
bitnamilegacy/postgresql-repmgr:14is consistent with the PR's objective. However, unlikedatabase-postgres/package-metadata.jsonwhich pins the image with a SHA256 digest, this reference uses only a tag. Consider adding a digest for reproducible deployments and to guard against unexpected image changes.database-postgres/package-metadata.json (1)
12-16: Good use of digest pinning forPOSTGRES_IMAGE; consider the same forPG_POOL_IMAGE.The SHA256 digest on
POSTGRES_IMAGEensures reproducible deployments. For consistency and the same security benefits, consider adding a digest toPG_POOL_IMAGEas well.,
| "dependencies": [], | ||
| "environmentVariables": { | ||
| "KAFKA_IMAGE": "bitnami/kafka:3.4.0", | ||
| "KAFKA_IMAGE": "bitnamilegacy/kafka:3.4.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🌐 Web query:
bitnamilegacy kafka Docker Hub image maintenance
💡 Result:
bitnamilegacy/kafka on Docker Hub is not maintained: it’s a legacy backup of older Bitnami Kafka images that will receive no further updates or support and is intended only for temporary migration; it may also be removed in the future, so you should mirror any tags you still depend on into your own registry. [1]
For ongoing maintenance/security updates, Bitnami directs users to move to Bitnami Secure Images, e.g. bitnami/kafka. [1][2]
🌐 Web query:
bitnamilegacy Docker repository security updates
💡 Result:
docker.io/bitnamilegacy/* images do not receive security updates.
- Bitnami’s own announcement for the 2025 catalog change says the Legacy repository (“docker.io/bitnamilegacy”) contains archived images that “will no longer receive updates, fixes, or support” and is intended only as a temporary fallback during migration. [1]
- Individual Docker Hub pages for
bitnamilegacy/*(example:bitnamilegacy/nginx) explicitly warn: “This repository is no longer updated… will receive no further updates or support” and note it may be removed in the future. [2]
If you need ongoing security patching, Bitnami directs users to Bitnami Secure Images (paid) rather than bitnamilegacy. [1]
Sources: [1] [2]
🌐 Web query:
bitnamilegacy/kafka:3.4.0 Docker image
💡 Result:
bitnamilegacy/kafkais Bitnami’s frozen/unsupported “legacy” repo: it receives no further updates/support and may be removed in the future (Bitnami recommends mirroring any tags you still depend on). [1]- For Kafka 3.4.0, the Bitnami (non-legacy) image tag exists as
bitnami/kafka:3.4.0(APP_VERSION=3.4.0; Debian 11–based). Pull:docker pull bitnami/kafka:3.4.0. [2] - If you were looking for an official ASF Kafka Docker image, note that
apache/kafkaimages are available starting at Kafka 3.7.0 (so there is noapache/kafka:3.4.0). [3]
Sources: [1] Docker Hub: bitnamilegacy/kafka overview (legacy/no longer updated) • [2] Tag details for bitnami/kafka:3.4.0 • [3] Apache Kafka Docker docs (availability from 3.7.0)
Do not use bitnamilegacy/kafka:3.4.0—this image receives no security updates and may be removed without notice.
The bitnamilegacy repository contains frozen, unmaintained images with explicit warnings that they will receive no further updates or support and are intended only as a temporary fallback during migration. Use bitnami/kafka:3.4.0 from the maintained repository instead, or update to a newer supported version. If you must retain this legacy image, mirror it to your own registry as Bitnami explicitly recommends.
🤖 Prompt for AI Agents
In `@message-bus-kafka/package-metadata.json` at line 9, The KAFKA_IMAGE metadata
entry currently points to the unmaintained legacy image
"bitnamilegacy/kafka:3.4.0"; update the value of the KAFKA_IMAGE key to use the
supported Bitnami image (e.g., "bitnami/kafka:3.4.0" or a newer supported tag)
or, if you must keep that exact legacy image, document and replace it with a
mirrored image in your own registry; edit the package-metadata.json KAFKA_IMAGE
entry to one of these supported options and ensure any deployment manifests
referencing KAFKA_IMAGE use the new value.
drizzentic
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I think we need to figure out if we can also host some of this images in our harbour registry just incase they are removed from dockerhub.
Summary
This PR fixes Loki's network configuration so Grafana and Promtail can reach it, and updates all Bitnami Docker image references to the
bitnamilegacyrepository.Changes
1. Monitoring – Loki on default network
minionetwork, so services on the stack's default network (e.g. Grafana, Promtail) could not resolve or reachloki:3100.defaultnetwork inmonitoring/docker-compose.ymlwhile keeping it onminiofor MinIO storage.2. Bitnami – bitnamilegacy image migration
Context: Bitnami's Docker images have moved to the
bitnamilegacyrepository.Change: All
bitnami/image references are updated tobitnamilegacy/in package metadata:database-postgrespostgresql-repmgr,pgpoolidentity-access-manager-keycloakpostgresql-repmgrclient-registry-jempipostgresql-repmgrclient-registry-santempipostgresql-repmgrmessage-bus-kafkaKafka imageSummary by CodeRabbit