-
Notifications
You must be signed in to change notification settings - Fork 1
Update java version #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
testImplementation "org.mockito:mockito-core:3.+"
Updated ArchUnit calls, removed unnecessary classes
1. fix day01 part2 2. show results in frontend
|
Hi all, |
|
@jenarp Has the problem been resolved? |
|
@Matthimatiker Due to Heroku I tried a lot of things, thus I decided this is not worth a Pull Request at the moment. At the moment app is running locally but deployment with Heroku ist still an issue. |
|
We have discussed the option of deploying Docker images instead. |
|
As the app runs locally with Java 17 and Heroku claims to support Java 17 (https://devcenter.heroku.com/articles/java-support), it might also be possible to switch to a plain Java buildpack (instead of the Gradle buildpack) and run |
|
@jenarp: could you reopen this PR so that I could check out the logs at Heroku? I would suggest trying Matthias' suggestion! |
Dear Team (especially @mfbieber, @basseur, @bonndan, @Matthimatiker),
if you desire to use the java, spring, etc. updated AoC version please have a look if everything is correct.
Regarding the frontend I got into trouble showing the results (answer text) on the Cards. They were not visible anymore after changes in AdventOfCodeController.java (DayModel).
Robert and I adjusted the changes in CardTemplate.js. Not sure if this is a clean fix.