Skip to content

[JENKINS-61290] hard to see why a branch was not inspected - log them #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

[JENKINS-61290] hard to see why a branch was not inspected - log them #318

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
cfcfdf1
[JENKINS-61290] hard to see why a branch was not inspected - log them
jimklimov Jun 9, 2020
052fc77
Merge branch 'master' into log-ignored-branches
jimklimov Jan 10, 2021
f95276b
Merge branch 'master' into log-ignored-branches
bitwiseman Jul 8, 2021
88797dd
Merge branch 'master' into log-ignored-branches
lifeofguenter Nov 15, 2021
731d988
Merge branch 'master' into log-ignored-branches
lifeofguenter Jan 14, 2022
24799f8
Merge branch 'master' into log-ignored-branches
lifeofguenter Aug 24, 2022
54bdc13
Merge branch 'master' into log-ignored-branches
lifeofguenter Jun 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/main/java/com/cloudbees/jenkins/plugins/bitbucket/BranchDiscoveryTrait.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,6 +245,12 @@ public boolean isExcluded(@NonNull SCMSourceRequest request, @NonNull SCMHead he
BitbucketRepository source = pullRequest.getSource().getRepository();
if (fullName.equalsIgnoreCase(source.getFullName())
&& pullRequest.getSource().getBranch().getName().equals(head.getName())) {
// End the format with newline to avoid logging this
// result blocked together with a later indexed branch
request.listener().getLogger().format(
"Ignoring %s because current strategy excludes branches "
+ "that ARE also filed as a pull request%n"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please write all words in lower case

, head.toString());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you report in #284 the output log seems to be

Checking branch featureimage/new-nut-configurator
Ignoring SCMHead{'featureimage/new-nut-configurator'} because current strategy excludes branches that ARE also filed as a pull request

Instead of head.toString() could you use a method to produce a readable the branch name as in the above log branch featureimage/new-nut-configurator ?

return true;
}
}
Expand Down Expand Up @@ -272,6 +278,10 @@ public boolean isExcluded(@NonNull SCMSourceRequest request, @NonNull SCMHead he
return false;
}
}
request.listener().getLogger().format(
"Ignoring %s because current strategy excludes branches "
+ "that ARE NOT also filed as a pull request%n"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please write all words in lower case

, head.toString());
return true;
}
return false;
Expand Down