Skip to content

[JENKINS-74135] extract inline JS script in AbstractDependencyGraphAction/jsplumb.jelly#38

Open
shlomomdahan wants to merge 1 commit intojenkinsci:masterfrom
shlomomdahan:JENKINS-74135
Open

[JENKINS-74135] extract inline JS script in AbstractDependencyGraphAction/jsplumb.jelly#38
shlomomdahan wants to merge 1 commit intojenkinsci:masterfrom
shlomomdahan:JENKINS-74135

Conversation

@shlomomdahan
Copy link

@shlomomdahan shlomomdahan commented Dec 5, 2024

JENKINS-74135

This PR extracts the inline <Script> tag in AbstractDependencyGraphAction/jsplumb.jelly to comply with CSP.

Testing done

BEFORE-CHANGES:
https://github.com/user-attachments/assets/bbd30549-dda9-4b2f-acc7-a90d9ab57b81

AFTER-CHANGES:

Screen.Recording.2024-12-05.at.1.55.07.PM.mov

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@jonesbusy
Copy link

CC @guidograzioli

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants