Pattern adapted to determine whether Jenkins is running in a container when podman is used with cgroup v2 #350
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r when podman is used with cgroup v2 The docker-workflow plugin also works perfectly with podman. After switching podman to cgroup v2, it is no longer recognised when Jenkins is running in a podman container. In order for this to work again, the regular expression needs to be adjusted. After the adjustment, the containerid is recognised correctly for both docker and podman. The expression used utilises lookbehind and lookahead expressions to determine the containerid.
|
Yep, Im running into same issue. Without testing this fix seems to have a correct regex for podman |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docker-workflow plugin also works perfectly with podman. After switching podman to cgroup v2, it is no longer recognised when Jenkins is running in a podman container. In order for this to work again, the regular expression needs to be adjusted. After the adjustment, the containerid is recognised correctly for both docker and podman. The expression used utilises lookbehind and lookahead expressions to determine the containerid.
Tests are implemented in ContainerisedCGroupV2Test and run without errors.