Disable encoding on jelly pages that generate HTML#8
Open
frankracis-work wants to merge 1 commit intojenkinsci:masterfrom
frankracis-work:xssfix
Open
Disable encoding on jelly pages that generate HTML#8frankracis-work wants to merge 1 commit intojenkinsci:masterfrom frankracis-work:xssfix
frankracis-work wants to merge 1 commit intojenkinsci:masterfrom
frankracis-work:xssfix
Conversation
Jenkins 2.146/2.138.2 changed the default setting for Jelly to encode by default. https://www.stackovercloud.com/2018/10/11/important-security-updates-for-jenkins/ This causes HTML output from this plugin to be escaped, displaying to the user as the literal HTML text. This change disables escaped-by-default on the two pages that generate HTML output directly.
|
As this repository doesn't seem to get a lot of attention from the owner, you can add this change yourself after installing the Emma plugin and going into C:\Program Files (x86)\Jenkins\plugins\emma\WEB-INF\lib\Classes.jar and implementing the changes manually in the contents of the jar file. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jenkins 2.146/2.138.2 changed the default setting for Jelly to encode by default.
https://www.stackovercloud.com/2018/10/11/important-security-updates-for-jenkins/
This causes HTML output from this plugin to be escaped, displaying to the user as the literal HTML text.
This change disables escaped-by-default on the two pages that generate HTML output directly.