Address ConcurrentModificationException which occasionally happens during XStream saving of running workflows [JENKINS-76294] #181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…zed [JENKINS-76294] Signed-off-by: Jim Klimov <jimklimov+jenkinsci@gmail.com>
…erialization [JENKINS-76294] Signed-off-by: Jim Klimov <jimklimov+jenkinsci@gmail.com>
… them in constructor(s) [JENKINS-76294] Signed-off-by: Jim Klimov <jimklimov+jenkinsci@gmail.com>
Author
|
For now, posting first the proposed solution to check it would not explode on Jenkins CI farm. As noted above, maven test crashed for me locally even on master branch anyway. |
Author
|
Apparently, current Jenkins CI farm can not build (pass tests of) the plugin too. Oh joy... |
jimklimov
changed the title
Author
|
Test failures as such seem to not be related to the PR change, as there are relatively few of those in https://ci.jenkins.io/job/Plugins/job/github-autostatus-plugin/job/PR-181/1/pipeline-overview/log?nodeId=53 : The I am less certain about There are however about 400 mentions of |
Author
|
Stack traces due to the original issue were still seen after updating other plugins with CME concerns (lockable-resources here), but leaving this one at 3.6.2: Now restarted that controller with a private build bypassing the tests ( |
Author
|
FWIW, the exception was not seen during the past week worth of builds... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://issues.jenkins.io/browse/JENKINS-76294, #180 and jenkinsci/lockable-resources-plugin#825 (for example of similar problem and fix).
Testing done
So far none. The
BuildStatusAction.javadoes not seem to use aJenkinsRuleso a new test class would be needed.In fact, plugin tests failed for me locally even on the unmodified master branch, so a new failing (later fixed) test would be a bit invisible.
Submitter checklist