Skip to content

Conversation

@The-Jonsey
Copy link

@The-Jonsey The-Jonsey commented Nov 13, 2025

I've been experiencing errors with rate limits on the organization folder scan, and checking out merge requests, due to GitLab reducing the API limit to these endpoints to 60/minute (https://gitlab.com/gitlab-org/gitlab/-/issues/580116), to resolve this I've added retries and backoff to the getMembers method in GitLabSCMSource

Resolves JENKINS-76277

Testing done

I've written unit tests for the getMembers method, this has also been tested on my jenkins server by creating an organization folder, forcibly using up my API limit on my access token, then running a scan and the retries successfully ran.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests that demonstrate the feature works or the issue is fixed

@The-Jonsey The-Jonsey requested a review from jetersen as a code owner November 13, 2025 20:13
@quinont
Copy link

quinont commented Nov 13, 2025

Thank you so much. I hope they try it and gets approved soon. This is the best Christmas present since the World Cup...

@The-Jonsey The-Jonsey force-pushed the feature/Add-Retries-And-Backoff-To-GitLabSCMSource branch from 82e52ef to 472b8f7 Compare November 14, 2025 16:10
@The-Jonsey
Copy link
Author

Apparently Pager wraps the GitLabApiException in a RuntimeException, added a method to handle that

@The-Jonsey The-Jonsey force-pushed the feature/Add-Retries-And-Backoff-To-GitLabSCMSource branch from 472b8f7 to a4a31b0 Compare November 14, 2025 16:18
@The-Jonsey
Copy link
Author

@jetersen could this get a review pls, I imagine its causing havoc on a good amount of Jenkins instances

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants