Add Retries And Backoff To GitLabSCMSource:getMembers #519
+173
−19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been experiencing errors with rate limits on the organization folder scan, and checking out merge requests, due to GitLab reducing the API limit to these endpoints to 60/minute (https://gitlab.com/gitlab-org/gitlab/-/issues/580116), to resolve this I've added retries and backoff to the
getMembersmethod inGitLabSCMSourceResolves JENKINS-76277
Testing done
I've written unit tests for the
getMembersmethod, this has also been tested on my jenkins server by creating an organization folder, forcibly using up my API limit on my access token, then running a scan and the retries successfully ran.Submitter checklist