[JENKINS-55813] Improve analysis of the AD attributes#34
[JENKINS-55813] Improve analysis of the AD attributes#34Wadeck wants to merge 2 commits intojenkinsci:masterfrom
Conversation
jvz
left a comment
jvz
left a comment
There was a problem hiding this comment.
Small changes to consider, but otherwise looks good.
| // documentation: https://docs.microsoft.com/en-us/windows/desktop/adschema/a-accountexpires | ||
| // code inspired by https://community.oracle.com/thread/1157460 | ||
| private static long getWin32EpochHundredNanos() { | ||
| GregorianCalendar win32Epoch = new GregorianCalendar(1601, Calendar.JANUARY, 1); |
There was a problem hiding this comment.
ZonedDateTime.of(1601, 1, 1, 0, 0, 0, 0, ZoneOffset.UTC) could be easier to calculate with here.
There was a problem hiding this comment.
- I followed the code as mentioned in the javadoc
- I do not find the proposed one to be more readable than the one in the PR
If anybody else agree on your proposal I will change ;)
There was a problem hiding this comment.
My proposal was taking a random java.time class that sounded appropriate. Calendar is much more annoying to use.
|
🤷♀️ This is beyond my ken! |
|
Do you think that |
|
Taking a fresh look at this, I believe the configured |
4 participants
See JENKINS-55813.