Replace Apache Commons Lang 2 with Java APIs due to removal from core and security issue#618
Merged
jglick merged 1 commit intojenkinsci:masterfrom Jan 20, 2026
Conversation
… and security issue
jglick
approved these changes
Jan 20, 2026
| public String getId() { | ||
| if (StringUtils.isEmpty(this.id)) { | ||
| if (this.id == null || this.id.isEmpty()) { | ||
| this.id = generateId(); |
Member
There was a problem hiding this comment.
hmm probably deserves rewrite like jenkinsci/scm-api-plugin#357
|
|
||
| public boolean isGeneratingPrefixRoles() { | ||
| return StringUtils.isNotBlank(rolePrefix) || convertToUpperCase; | ||
| return (rolePrefix != null && !rolePrefix.isBlank()) || convertToUpperCase; |
Member
There was a problem hiding this comment.
I am guessing a PR like this is mechanically generated. True cleanup would mean reading the code to figure out whether a rolePrefix of "" (much less " ") was ever actually possible, and if so, cleaning up properly by picking either null or "" at the point at which such a field is written.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #372
Testing done
mvn -DskipTests clean install
Submitter checklist