Skip to content

[JENKINS-74151] Extract inline onBlur and JS script in ReleaseStep/config.jelly #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shlomomdahan wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[JENKINS-74151] Extract inline onBlur and JS script in ReleaseStep/config.jelly #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 6 additions & 20 deletions src/main/resources/hudson/plugins/release/pipeline/ReleaseStep/config.jelly
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,30 +25,16 @@ THE SOFTWARE.

<?jelly escape-by-default='true'?>
<j:jelly xmlns:j="jelly:core" xmlns:f="/lib/form" xmlns:st="jelly:stapler">
<st:adjunct includes="hudson.plugins.release.pipeline.ReleaseStep.load-params"/>
<j:set var="jobFieldId" value="${h.generateId()}"/>
<span
class="release-params-data"
data-descriptor-url="${descriptor.descriptorUrl}"
data-context="${descriptor.context}"/>
<f:entry field="job" title="${%Job to Release}">
<f:textbox onblur="loadParams()" id="${jobFieldId}"/>
<f:textbox clazz="release-load-params" id="${jobFieldId}"/>
</f:entry>
<f:entry title="${%Parameters}">
<div id="params"/>
<script>
function loadParams() {
const div = document.getElementById('params');
const parametersTextBox = document.getElementById('${jobFieldId}')

const url = '${descriptor.descriptorUrl}/parameters?job=' + encodeURIComponent(parametersTextBox.value) + '&amp;context=' + encodeURIComponent('${descriptor.context}')
fetch(url)
.then(rsp => {
if (rsp.ok) {
rsp.text().then(responseText => {
div.innerHTML = responseText;
Behaviour.applySubtree(div);
})
} else {
div.innerHTML = "<b>ERROR</b>: Failed to load parameter definitions: " + rsp.statusText;
}
})
}
</script>
</f:entry>
</j:jelly>
25 changes: 25 additions & 0 deletions src/main/resources/hudson/plugins/release/pipeline/ReleaseStep/load-params.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
Behaviour.specify('.release-load-params', 'release-load-params', 0, function(e) {
e.addEventListener('blur', function() {
const dataSpan = document.querySelector('.release-params-data');
const div = document.getElementById('params');

const url = dataSpan.dataset.descriptorUrl + '/parameters?job=' +
encodeURIComponent(this.value) +
'&context=' + encodeURIComponent(dataSpan.dataset.context);

fetch(url)
.then(rsp => {
if (rsp.ok) {
return rsp.text();
}
throw new Error(rsp.statusText);
})
.then(responseText => {
div.innerHTML = responseText;
Behaviour.applySubtree(div);
})
.catch(error => {
div.innerHTML = '<b>ERROR</b>: Failed to load parameter definitions: ' + error.message;
});
});
});