Don't cache whole scripts in development mode, allows sub resources to hot reload again#279
Open
timja wants to merge 1 commit intojenkinsci:masterfrom
Open
Don't cache whole scripts in development mode, allows sub resources to hot reload again#279timja wants to merge 1 commit intojenkinsci:masterfrom
timja wants to merge 1 commit intojenkinsci:masterfrom
Conversation
This was referenced Oct 29, 2021
jglick
reviewed
Oct 29, 2021
Member
jglick
left a comment
jglick
left a comment
There was a problem hiding this comment.
IIUC this will only cache custom taglibs, which is a use case most plugins do not even touch except insofar as they might use some from core (mainly in configuration screens with /lib/form).
Member
Author
correct |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative to #278
Tested and it works, seems snappy enough but would appreciate feedback
Fixes #221
cc @basil if you have any opinion