Replace AbstractProject and AbstractBuild with Job and Run#107
Merged
jakub-bochenski merged 2 commits intojenkinsci:masterfrom Jul 5, 2019
proski:pipeline-prepare
Merged
Replace AbstractProject and AbstractBuild with Job and Run#107jakub-bochenski merged 2 commits intojenkinsci:masterfrom proski:pipeline-prepare
jakub-bochenski merged 2 commits intojenkinsci:masterfrom
proski:pipeline-prepare
Conversation
jakub-bochenski
approved these changes
Jun 27, 2019
This makes it possible to support pipelines. Pipelines don't use AbstractProject and AbstractBuild. Instead, they use WorkflowJob and WorkflowRun. The common ancestors are Job and Run. In some cases, Job doesn't provide the needed API. However, both AbstractProject and WorkflowJob implement ParameterizedJob interface, which provides the required functionality.
|
@proski Feel free to add your code as you wish, far as I'm concerned, if it helps. :) |
Author
|
A fix is needed for a compile error, I've submitted a one-line fix: #114 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the commit from #69 that converts the remaining code to the types compatible with pipelines. It doesn't enable pipeline support, but it includes changes necessary to support pipelines.
The patch was authored by @rhencke and I'm not going to add my code to it, such as unit tests. I can add them separately.