getting jenkins root url from Jenkins class instance#27
getting jenkins root url from Jenkins class instance#27tomascea wants to merge 1 commit intojenkinsci:masterfrom
Conversation
|
The broken link in Stash posts is the biggest annoyance with the new Jenkins. Thank you for fixing the issue. Please merge and release soon! |
|
@tomascea : just in case, is your PR a sort of duplicate (alternative) to my #26 which I think it is? Just in case, ask someone from IRC to review it, because I also started the fixed logic as big and branchey, but in the end at jenkinsci/jenkins#3570 (comment) was recommended to use the single global object getter, so the change to fix became a one-liner. |
goostleek
left a comment
goostleek
left a comment
There was a problem hiding this comment.
I think the #26 from @jimklimov fixes the same issue in a much more concise way.
| if (!rootUrl.isEmpty()){ | ||
| buildUrl = rootUrl + build.getUrl(); | ||
| }else{ | ||
| buildUrl = "Jenkins instance root URL is empty "+ build.getUrl(); |
There was a problem hiding this comment.
I think the previous message (PLEASE SET JENKINS ROOT URL FROM GLOBAL CONFIGURATION) is more valuable for the user. It says precisely to adjust Jenkins configuration to get the proper build URL.
4 participants
No description provided.