Rename StashAditionalParameterEnvironmentContributor

[proski]

*  Rename StashAditionalParameterEnvironmentContributor
   
   Not only did the old class name have a typo, a "contributor" is already
   implied to provide something additional.
   
   Also remove a reference to parameters, which are not used in that code
   anymore.

[jakub-bochenski]

Just checking: won't this result in a breaking change to the xml config?

[proski]

Good question. That name doesn't appear in any files in JENKINS_HOME apart from the plugin binary. It's not in the xml files.

[jakub-bochenski]

I think we should do a new release soon, e.g. after merging this

[proski]

I'm OK with the release. We have accumulated some good stuff in the master branch. I don't have anything user-visible ready for submission.

Preliminary release notes:

• Added help to all fields
• Log warnings about undefined parameters have been fixed (they can still appear when xml files for older builds are loaded)
• The environment variables added by the plugin are visible in child jobs of multi-configration projects
• Post-build comments work in multi-configration projects
• The quiet period setting is respected
• Logs show correct classes

[proski]

Please have a look at #64, it's a one line change with a user visible effect.

Can we have gitter for this project? If not, https://gitter.im/nemccarthy/stash-pullrequest-builder-plugin is available.

PR comments is not the best place to discuss releases and other project-wide questions.

[proski]

Please also consider #70 for the release, it's very small and it improves user experience.

[proski]

Also #71. I would appreciate if somebody just merges simple non-controversial PRs. I have many ideas for improving the code, but I'm already sitting on a pile of trivial things that are not getting applied, and they often overlap 😞

[jakub-bochenski]

@jimklimov I would like to merge this ASAP

[jakub-bochenski]

Can we have gitter for this project? If not, https://gitter.im/nemccarthy/stash-pullrequest-builder-plugin is available.

Added a new gitter room, let's see how this pans out