StashRepository: Change constructor to get needed objects directly#90
Closed
proski wants to merge 1 commit intojenkinsci:masterfrom
proski:direct-arguments
Closed
StashRepository: Change constructor to get needed objects directly#90proski wants to merge 1 commit intojenkinsci:masterfrom proski:direct-arguments
proski wants to merge 1 commit intojenkinsci:masterfrom
proski:direct-arguments
Conversation
The StashPullRequestsBuilder object is not needed, but the project and the trigger are used a lot, so pass them to the constructor. Annotate the constructor arguments with @nonnull. No need to defer setting trigger until the init() call, it is not going to change. Passing the needed objects directly simplifies mock object injection in unit tests.
Merged
Author
|
Merged as part of #81, closing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both #81 and #86 need to make changes to this code. This is the common foundation for both.