StashBuildEnvironmentContributor: Pass environment variables to pipelines#96
Merged
jakub-bochenski merged 2 commits intojenkinsci:masterfrom Jun 3, 2019
proski:pipeline-environment
Merged
StashBuildEnvironmentContributor: Pass environment variables to pipelines#96jakub-bochenski merged 2 commits intojenkinsci:masterfrom proski:pipeline-environment
jakub-bochenski merged 2 commits intojenkinsci:masterfrom
proski:pipeline-environment
Conversation
Author
|
I've added unit tests. The first commit adds unit tests for the existing code. The second commit changes the main code and updates the unit tests for the new behavior. |
jakub-bochenski
approved these changes
May 24, 2019
jakub-bochenski
left a comment
There was a problem hiding this comment.
I think we can just merge it independently since it doesn't require pipeline to work and improves the test coverage
…ines Add environment variables to every Run caused by StashCause even if it's not an instance of AbstractBuild.
Author
|
Fixed raw type warnings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split from #69, as it's possible to set up a pipeline without relying on the environment variables provided by the plugin (although I would definitely recommend using
sourceCommitHashto make sure the plugin tests what Bitbucket Server expects to be tested).