[JENKINS-39318] tearDown() not called for build environments with "Use build environment from another project". #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calin-iorgulescu
commented
Nov 10, 2016
calin-iorgulescu
commented
- Fixes the existing issue with tearDown() not being called by the ProxyBuildEnvironment. This can cause leaks and also disrupts the way some build environment tools function.
- Concrete case: The build-timeout plugin uses tearDown() to reset internal timers. The Android emulator plugin uses tearDown() to clean up certain artifacts.
calin-iorgulescu
changed the title
calin-iorgulescu
changed the title
Contributor
|
Same thing, maybe throw on at test? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.