Make showreview comment numbering consistent#110
Open
fekblom wants to merge 2 commits intojensl:masterfrom
Open
Make showreview comment numbering consistent#110fekblom wants to merge 2 commits intojensl:masterfrom
fekblom wants to merge 2 commits intojensl:masterfrom
Conversation
Previously, in a thread with the original comment + 1 extra comment that had been read by the user Critic would display the number of comments as: 1 reply. Adding a second reply (bringing the total number of comments to 3) would be displayed to the user as: 1 out of 3 unread. After marking that thread as read it will go back to display as: 2 replies. This commit make the "total" number always refer to the number of replies instead of alternating between the number of replies and the number of comments in total (including the original one).
Owner
|
Reviewed in https://critic-review.org/r/361. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, in a thread with the original comment + 1 extra comment that had
been read by the user Critic would display the number of comments as: 1 reply.
Adding a second reply (bringing the total number of comments to 3) would be
displayed to the user as: 1 out of 3 unread. After marking that thread as read
it will go back to display as: 2 replies.
This commit make the "total" number always refer to the number of replies
instead of alternating between the number of replies and the number of comments
in total (including the original one).