Fix crashes caused by system installed extensions.#129
Fix crashes caused by system installed extensions.#129ohrn wants to merge 1 commit intojensl:masterfrom
Conversation
System extensions do not have an author set.
|
"Imported" as https://critic-review.org/r/415 for testing. I'll merge this to the stable/1 branch first. That's the branch you will want to follow anyway. On your suggestion for an improved fix: in some cases, maybe. But really there are two roles involved: the "author", which is defined in the To make this more confusing, the "publisher" role is called "author" in many places in the code. It's has traditionally been the same human being, but its really two distinct roles. So: in some cases, the actual author was intended, in which case the information from the |
This is a quick fix to avoid crashes in a couple of places. System extensions do not have a Critic user account set as author.
An improved fix for the future would be to use the author information in the extension manifest.