Use real manifest path for extension snapshots#139
Open
pitkali wants to merge 1 commit intojensl:masterfrom
Open
Use real manifest path for extension snapshots#139pitkali wants to merge 1 commit intojensl:masterfrom
pitkali wants to merge 1 commit intojensl:masterfrom
Conversation
When extension.getManifest() is asked for manifest of a given sha1, it reads the manifest from the snapshot directory. It then synthesises an invalid path, for some reason. This makes the created manifest unusable for actually running extensions. But the extension has a snapshot on disk from which this manifest was read! So return the install_path of that snapshot. This fixes ability to run non-LIVE versions of filterhook role, which uses getManifest to avoid reading the manifest too often. Fixes: jensl#138
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When extension.getManifest() is asked for manifest of a given sha1, it
reads the manifest from the snapshot directory. It then synthesises an
invalid path, for some reason. This makes the created manifest unusable
for actually running extensions.
But the extension has a snapshot on disk from which this manifest was
read! So return the install_path of that snapshot.
This fixes ability to run non-LIVE versions of filterhook role, which
uses getManifest to avoid reading the manifest too often.
Fixes: #138