You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
hi, thanks a lot for your contributions :)
to make the translation work, you need to move strings.xml into values-zh-rCN.
also, could i get you to be a little more descriptive in your commit messages? mentioning that you update strings.xml for chinese would be nice.
and lastly: i really appreciate your work and it will be merged as soon as strings.xml is in the right directory, but translation work is probably best done via transifex.
i'm so sorry, i don't know how i missed that. you should have permissions now.
but i think it's easier if we do the first import of the translation through git.
the only problem right now is that your changes don't compile. res/values-zh-rCN/strings.xml:L.101 has apostrophes which are not escaped. they need to be written as \' (i would do it myself, but i think it's best that you do it since i can't read the context they are in).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.