Open
Conversation
This reduces memory usage by eliminating the redundant key pointer.
Owner
|
@jonhartnett I'm extremely sorry for the delay following up here. I had meant to respond when the issue was first opened, but I forgot to do so promptly and ended up completely losing track of this 🤦. If it's possible to break these changes into multiple smaller PR's that would greatly help me review the changes 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disclaimer: This PR is kind of big. I recommend reviewing it patch-by-patch instead of all at once, which will make the individual atomic changes a lot easier to follow.
This PR is the result of a bunch of improvements that I made on my local fork that I thought I'd share upstream. Incidentally, they happen to solve many of the open issues. All changes have associated documentation and were validated against the existing tests + doc tests. New tests and doc tests were introduced where appropriate to validate new features.
Overview:
I realize this is a lot to review on one go, so if you have issues with any of the individual commits, lmk and I can resubmit as individual PRs.