Add get_or_insert_with_key#229
Merged
jeromefroe merged 2 commits intojeromefroe:masterfrom Apr 13, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the LruCache API with *_or_insert_with_key variants that pass &K into the value-construction closure, reducing the need for cloning keys solely to capture them in FnOnce.
Changes:
- Added
get_or_insert_with_key,try_get_or_insert_with_key,get_or_insert_mut_with_key, andtry_get_or_insert_mut_with_key. - Refactored existing
get_or_insert*/try_get_or_insert*methods to delegate to the new*_with_keyvariants. - Added unit tests covering the new APIs.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Owner
|
Thank you for the contribution @pikatos |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add get_or_insert_with_key variant. If the key is needed to create a new value to populate the cache, using only get_or_insert implies the use of a cloneable key to be able to capture the key in the provided closure. Wrapping the key with Rc and using get_or_insert_ref just for that seems overkill.
becomes: