Skip to content

Fix: avoid 1B OOB read at EOF after class static block (Fixes #5254) #5261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix: avoid 1B OOB read at EOF after class static block (Fixes #5254) #5261

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions jerry-core/parser/js/js-parser-expr.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -857,8 +857,15 @@ parser_parse_class_body (parser_context_t *context_p, /**< context */

parser_stack_push (context_p, &range.start_location, sizeof (scanner_location_t));
fields_size += sizeof (scanner_location_t);

lexer_consume_next_character (context_p);

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

if (JERRY_UNLIKELY(context_p->source_p >= context_p->source_end_p))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (JERRY_UNLIKELY(context_p->source_p >= context_p->source_end_p))
if (JERRY_UNLIKELY (context_p->source_p >= context_p->source_end_p))

{
parser_raise_error (context_p, PARSER_ERR_PROPERTY_IDENTIFIER_EXPECTED);
}
else
{
lexer_consume_next_character (context_p);
}
Comment on lines +865 to +868
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we don't need else as parser_raise_error will stop the execution.

Suggested change
else
{
lexer_consume_next_character (context_p);
}
lexer_consume_next_character (context_p);

}
else if (lexer_consume_assign (context_p))
{
Expand Down