Merged
Conversation
This PR includes multiple improvements and bug fixes: ## Cherry-picked Features from gwlsn/shrinkray: - Add optional tabbed layout with configuration options - Tabbed layout UI fixes (scrolling, settings overlay) - Allow settings tab to scroll in tabs layout - Show settings overlay only on settings tab ## Code Audit Fixes (High/Medium Severity): - handler.go: Handle ignored JSON encode error in writeJSON() - oidc/provider.go: Remove dead code (unused stateCookieSameSite func) - hwaccel.go: Fix typo VAAAPIHealthCheck → VAAPIHealthCheck - queue.go: Replace fmt.Printf with log.Printf for consistent logging - ntfy.go: Add HTTP client with 30s timeout, drain response body - pushover.go: Add HTTP client with 30s timeout, drain response body ## Bug Fix: Running Jobs Disappear on Page Refresh - Root cause: updateJobs() only added queue jobs to statusIndex, not running jobs - Fix: Also index running jobs for status lookups in updateActivePanel() - Includes regression test to prevent this bug from reoccurring ## Testing - Added E2E regression test for running jobs refresh bug - All changes verified with code analysis and LSP diagnostics
The function is used by clearStateCookie() and was mistakenly identified as dead code during the audit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR includes multiple improvements and bug fixes to shrinkray.
🔄 Cherry-picked Features from gwlsn/shrinkray
🐛 Bug Fix: Running Jobs Disappear on Page Refresh (Critical)
updateJobs()only indexed queue jobs instatusIndex, never running jobsjobMapandstatusIndexfor status lookups🔧 Code Audit Fixes (High/Medium Severity)
writeJSON()fmt.Printfwithlog.Printffor consistent loggingstateCookieSameSitefunctionVAAAPIHealthCheck→VAAPIHealthCheck🧪 Testing
Files Changed
web/templates/index.htmlinternal/api/handler.gointernal/auth/oidc/provider.gointernal/ffmpeg/hwaccel.gointernal/jobs/queue.gointernal/ntfy/ntfy.gointernal/pushover/pushover.goe2e/running-jobs-refresh.spec.tsdocs/faq.mdinternal/logger/logger.goTesting Instructions
Breaking Changes
None - all changes are backwards compatible