feat: accessibility improvements and settings reorganization#52
Merged
feat: accessibility improvements and settings reorganization#52
Conversation
…ation Accessibility (WCAG 2.1 AA compliance): - Add focus trap with inert background for all modals - Add role=dialog, aria-modal, aria-labelledby to modals - Add skip link for keyboard navigation - Add prefers-reduced-motion CSS support - Add proper ARIA attributes to tabs (tabpanel, arrow key nav) - Make preset cards keyboard accessible (role=button) - Improve color contrast for tertiary text - Add aria-labels to all form inputs and icon buttons - Add loading state announcements for screen readers Settings panel improvements: - Add Schedule settings (enable/disable, time window) - Add Quality settings (HEVC/AV1 CRF sliders) - Reorganize into collapsible sections - Show schedule status in header when active - Consolidate related settings (Interface section) Tests: - Expand e2e/accessibility.spec.ts from 3 to ~30 tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Comprehensive accessibility audit and settings panel improvements:
Accessibility Changes
Modals
role="dialog",aria-modal="true",aria-labelledbyto all modalsinertattribute on background contentKeyboard Navigation
role="button"with Enter/Space/Arrow key supportScreen Reader Support
aria-liveregionaria-labelon all form inputs and icon buttonsaria-hidden="true"Visual
prefers-reduced-motionCSS media query supportSettings Panel Changes
New Features (from gwlsn upstream)
Reorganization
Tests
Expanded
e2e/accessibility.spec.tsfrom 3 tests to ~30 tests covering: