Skip to content

Conversation

kyu08
Copy link
Contributor

@kyu08 kyu08 commented Oct 19, 2025

PR Description

I found that PR status becomes green even if no label added when we use Update branch on GitHub PR page.

So I added synchronize event to the hooks of Check Required Labels.

CleanShot 2025-10-19 at 21 57 00@2x

Actually, #4936 is green in spite of no label is added.

Please check if the PR fulfills these requirements

  • Cheatsheets are up-to-date (run go generate ./...)
  • Code has been formatted (see here)
  • Tests have been added/updated (see here for the integration test guide)
  • Text is internationalised (see here)
  • If a new UserConfig entry was added, make sure it can be hot-reloaded (see here)
  • Docs have been updated if necessary
  • You've read through your own file changes for silly mistakes etc

Testing

I tested this change fixes the problem I mentioned using my fork repo.

What I did is:

  1. Push this commit to master branch of my fork repository. It's almost same as this PR's change.
  2. Create a PR bases to master.
  3. Push new commit to master branch.
  4. Press "Update branch" in the PR.
  5. Ensure that PR status become red as expected.
CleanShot 2025-10-19 at 23 36 10@2x

@kyu08 kyu08 force-pushed the update-label-checker branch from 7cacd05 to 76948f8 Compare October 19, 2025 13:52
@kyu08 kyu08 marked this pull request as draft October 19, 2025 14:22
@stefanhaller
Copy link
Collaborator

LGTM. Why is it marked as draft though?

@kyu08
Copy link
Contributor Author

kyu08 commented Oct 19, 2025

Thanks for the review!
Simply I forgot mark as opened. 😅

@kyu08 kyu08 marked this pull request as ready for review October 19, 2025 15:28
@stefanhaller stefanhaller added the maintenance For refactorings, CI changes, tests, version bumping, etc label Oct 19, 2025
@stefanhaller stefanhaller merged commit d334bae into jesseduffield:master Oct 19, 2025
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance For refactorings, CI changes, tests, version bumping, etc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants