Add synchronize
event to the hooks of "Check Required Labels"
#4974
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
I found that PR status becomes green even if no label added when we use
Update branch
on GitHub PR page.So I added
synchronize
event to the hooks ofCheck Required Labels
.Actually, #4936 is green in spite of no label is added.
Please check if the PR fulfills these requirements
Cheatsheets are up-to-date (rungo generate ./...
)Code has been formatted (see here)Tests have been added/updated (see here for the integration test guide)Text is internationalised (see here)If a new UserConfig entry was added, make sure it can be hot-reloaded (see here)Docs have been updated if necessaryTesting
I tested this change fixes the problem I mentioned using my fork repo.
What I did is: