Skip to content

fix jest-editor-support tests breakage #508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Nov 20, 2019
Merged

fix jest-editor-support tests breakage #508

merged 8 commits into from
Nov 20, 2019

Conversation

connectdotz
Copy link
Collaborator

@connectdotz connectdotz commented Oct 7, 2019 •
edited
Loading

fix test breakage issue when linking with the newly update jest-editor-support see /jest-community/jest-editor-support#14, particular here

Note: this PR will failed ci until we pick up the next jest-editor-support

@connectdotz connectdotz requested a review from stephtr October 7, 2019 14:21
@coveralls
Copy link

coveralls commented Oct 7, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 659

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.245%
Totals Coverage Status
Change from base Build 647: 0.0%
Covered Lines: 731
Relevant Lines: 816
💛 - Coveralls

@connectdotz
Copy link
Collaborator Author

the ci error is due to testing with the old jest-editor-support, I will mark this PR has a dependency on the next release of jest-editor-support.

@stephtr
Copy link
Member

stephtr commented Oct 7, 2019

Thank you!
If there are no errors after releasing a new version of jest-editor-support, I'm happy with merging it.

@seanpoulter
Copy link
Member

Thank you!
If there are no errors after releasing a new version of jest-editor-support, I'm happy with merging it.

Me too. 👏

@seanpoulter seanpoulter self-requested a review October 12, 2019 15:53
seanpoulter
seanpoulter approved these changes Oct 12, 2019
View reviewed changes
Copy link
Member

@seanpoulter seanpoulter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to merge with the next version of jest-editor-support.
Should we expect that version bump in this PR?

@connectdotz
Copy link
Collaborator Author

ok, the new "jest-editor-support" 27.0.0 is out, I updated the package.json and adjusted the jest config because when installing from npm, some modules under "jest-editor-support/node_modules" got hoisted to the top, so we still have to explicitly unmock those in unmockedModulePathPatterns.

we should be ready to merge now.

@connectdotz connectdotz merged commit 3fef151 into jest-community:master Nov 20, 2019
@connectdotz connectdotz deleted the unmock-jest-editor-support-dependencies branch November 20, 2019 03:33
legend1202 pushed a commit to legend1202/vscode-jest that referenced this pull request Jun 18, 2023
@connectdotz
fix jest-editor-support tests breakage (jest-community#508)
9ff0caa 
* fix jest-editor-support tests breakage

* try escape path separator for ci

* adding more unmock patterns for ci

* undo previous change

* fix changelog

* update jest-editor-support versio and jest config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanpoulter seanpoulter seanpoulter approved these changes

@stephtr stephtr Awaiting requested review from stephtr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@connectdotz @coveralls @stephtr @seanpoulter