Skip to content

Conversation

Connormiha
Copy link
Contributor

I updated return type for isPrimitive to enable type narrowing, improve type safety, and give the compiler more context during type checks

Summary

Test plan

Copy link

netlify bot commented Aug 3, 2025

Deploy Preview for jestjs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit ad9150f
🔍 Latest deploy log https://app.netlify.com/projects/jestjs/deploys/688fc66d6497540008c06244
😎 Deploy Preview https://deploy-preview-15770--jestjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

pkg-pr-new bot commented Aug 3, 2025

Open in StackBlitz

babel-jest

npm i https://pkg.pr.new/babel-jest@15770

babel-plugin-jest-hoist

npm i https://pkg.pr.new/babel-plugin-jest-hoist@15770

babel-preset-jest

npm i https://pkg.pr.new/babel-preset-jest@15770

create-jest

npm i https://pkg.pr.new/create-jest@15770

@jest/diff-sequences

npm i https://pkg.pr.new/@jest/diff-sequences@15770

expect

npm i https://pkg.pr.new/expect@15770

@jest/expect-utils

npm i https://pkg.pr.new/@jest/expect-utils@15770

jest

npm i https://pkg.pr.new/jest@15770

jest-changed-files

npm i https://pkg.pr.new/jest-changed-files@15770

jest-circus

npm i https://pkg.pr.new/jest-circus@15770

jest-cli

npm i https://pkg.pr.new/jest-cli@15770

jest-config

npm i https://pkg.pr.new/jest-config@15770

@jest/console

npm i https://pkg.pr.new/@jest/console@15770

@jest/core

npm i https://pkg.pr.new/@jest/core@15770

@jest/create-cache-key-function

npm i https://pkg.pr.new/@jest/create-cache-key-function@15770

jest-diff

npm i https://pkg.pr.new/jest-diff@15770

jest-docblock

npm i https://pkg.pr.new/jest-docblock@15770

jest-each

npm i https://pkg.pr.new/jest-each@15770

@jest/environment

npm i https://pkg.pr.new/@jest/environment@15770

jest-environment-jsdom

npm i https://pkg.pr.new/jest-environment-jsdom@15770

@jest/environment-jsdom-abstract

npm i https://pkg.pr.new/@jest/environment-jsdom-abstract@15770

jest-environment-node

npm i https://pkg.pr.new/jest-environment-node@15770

@jest/expect

npm i https://pkg.pr.new/@jest/expect@15770

@jest/fake-timers

npm i https://pkg.pr.new/@jest/fake-timers@15770

@jest/get-type

npm i https://pkg.pr.new/@jest/get-type@15770

@jest/globals

npm i https://pkg.pr.new/@jest/globals@15770

jest-haste-map

npm i https://pkg.pr.new/jest-haste-map@15770

jest-jasmine2

npm i https://pkg.pr.new/jest-jasmine2@15770

jest-leak-detector

npm i https://pkg.pr.new/jest-leak-detector@15770

jest-matcher-utils

npm i https://pkg.pr.new/jest-matcher-utils@15770

jest-message-util

npm i https://pkg.pr.new/jest-message-util@15770

jest-mock

npm i https://pkg.pr.new/jest-mock@15770

@jest/pattern

npm i https://pkg.pr.new/@jest/pattern@15770

jest-phabricator

npm i https://pkg.pr.new/jest-phabricator@15770

jest-regex-util

npm i https://pkg.pr.new/jest-regex-util@15770

@jest/reporters

npm i https://pkg.pr.new/@jest/reporters@15770

jest-resolve

npm i https://pkg.pr.new/jest-resolve@15770

jest-resolve-dependencies

npm i https://pkg.pr.new/jest-resolve-dependencies@15770

jest-runner

npm i https://pkg.pr.new/jest-runner@15770

jest-runtime

npm i https://pkg.pr.new/jest-runtime@15770

@jest/schemas

npm i https://pkg.pr.new/@jest/schemas@15770

jest-snapshot

npm i https://pkg.pr.new/jest-snapshot@15770

@jest/snapshot-utils

npm i https://pkg.pr.new/@jest/snapshot-utils@15770

@jest/source-map

npm i https://pkg.pr.new/@jest/source-map@15770

@jest/test-result

npm i https://pkg.pr.new/@jest/test-result@15770

@jest/test-sequencer

npm i https://pkg.pr.new/@jest/test-sequencer@15770

@jest/transform

npm i https://pkg.pr.new/@jest/transform@15770

@jest/types

npm i https://pkg.pr.new/@jest/types@15770

jest-util

npm i https://pkg.pr.new/jest-util@15770

jest-validate

npm i https://pkg.pr.new/jest-validate@15770

jest-watcher

npm i https://pkg.pr.new/jest-watcher@15770

jest-worker

npm i https://pkg.pr.new/jest-worker@15770

pretty-format

npm i https://pkg.pr.new/pretty-format@15770

commit: ad9150f

Copy link
Member

@cpojer cpojer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@cpojer cpojer merged commit 6c09563 into jestjs:main Aug 27, 2025
72 checks passed
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants