Implement addMatchers shortcut on jest#323
Merged
DmitrySoshnikov merged 1 commit intojestjs:masterfrom May 11, 2015
yungsters:master
Merged
Implement addMatchers shortcut on jest#323DmitrySoshnikov merged 1 commit intojestjs:masterfrom yungsters:master
addMatchers shortcut on jest#323DmitrySoshnikov merged 1 commit intojestjs:masterfrom
yungsters:master
Conversation
Contributor
|
Seems fine. Might be worth adding a comment in the code that it will need to be updated if we upgrade to jasmine2. http://jasmine.github.io/2.0/upgrading.html |
Contributor
|
Shall we go with this PR? Also, we have the process of upgrading to jasmine2 in #330. |
Contributor
|
OK, seems it was merged internally already, so we can add it here. |
DmitrySoshnikov
added a commit
that referenced
this pull request
May 11, 2015
Implement `addMatchers` shortcut on `jest`
This was referenced Apr 13, 2021
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will make it easier to use arrow functions when writing unit tests that have custom matchers: