Curation - docker repo extraction fix #635
Open
+853
−139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basel1322
added
the
safe to test
github-actions
bot
removed
the
safe to test
basel1322
force-pushed
the
docker-repo-extraction-fix
branch
from
dee2630 to
8cda26a
Compare
basel1322
added
the
safe to test
github-actions
bot
removed
the
safe to test
attiasas
requested changes
Jan 4, 2026
Contributor
attiasas
left a comment
attiasas
left a comment
There was a problem hiding this comment.
Check out my comments, in addition:
- Update PR description with more information on the actual change/fix
- Make sure tests are passing
basel1322
added
the
safe to test
github-actions
bot
removed
the
safe to test
basel1322
added
the
safe to test
github-actions
bot
removed
the
safe to test
basel1322
added
the
safe to test
github-actions
bot
removed
the
safe to test
attiasas
added
the
safe to test
github-actions
bot
removed
the
safe to test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found an issue with jf ca when running the command against a JFrog registry that uses the repository path format, rather than the subdomain-based format.
The image being scanned was:
z0curation211355112.jfrogdev.org/curation-test/google-samples/hello-app:1.0
However, the command incorrectly identified the repository as:
z0curation211355112
In this scenario, the code:
Detected a JFrog domain
Assumed a subdomain-based repository layout
Incorrectly extracted z0curation211355112 as the repository name
The actual repository (curation-test) is correctly specified in the image path.