Skip to content

Conversation

@bio-boris
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jul 2, 2024

Codecov Report

Attention: Patch coverage is 94.35737% with 18 lines in your changes missing coverage. Please review.

Please upload report for BASE (master@916fa20). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...dmapping/storage/mongo/id_mapping_mongo_storage.py 85.29% 15 Missing ⚠️
src/jgikbase/idmapping/builder.py 90.00% 2 Missing ⚠️
src/jgikbase/idmapping/core/errors.py 91.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master     #131   +/-   ##
=========================================
  Coverage          ?   97.52%           
=========================================
  Files             ?       15           
  Lines             ?     1212           
  Branches          ?        0           
=========================================
  Hits              ?     1182           
  Misses            ?       30           
  Partials          ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@Xiangs18 Xiangs18 changed the title Develop -> Master 0.1.2 release (develop -> master) Nov 20, 2024
@Xiangs18 Xiangs18 marked this pull request as ready for review November 20, 2024 23:13
@Xiangs18 Xiangs18 requested a review from MrCreosote November 20, 2024 23:18
Copy link
Member

@MrCreosote MrCreosote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obviously not going to go through this line by line as it's all been reviewed already, but skimming the file changes and doing some spot checks looks good

@Xiangs18 Xiangs18 merged commit fa208ad into master Nov 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants