Skip to content

Feature/add more command managers#14

Open
vybhav-ibr wants to merge 9 commits intojgillick:mainfrom
vybhav-ibr:feature/add_more_command_managers
Open

Feature/add more command managers#14
vybhav-ibr wants to merge 9 commits intojgillick:mainfrom
vybhav-ibr:feature/add_more_command_managers

Conversation

@vybhav-ibr
Copy link
Copy Markdown

Adds the position command manager and the pose command manager and the accompanying reward functions for tracking

Comment on lines +197 to +202
"pos_x": pos_x_axis,
"pos_y": pos_y_axis,
"pos_z": pos_z_axis,
"euler_x": euler_x_axis,
"euler_y": euler_y_axis,
"euler_z": euler_z_axis,
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this will work as most gamepads only have 2 joysticks, but this is expecting 3. Have you tested this?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i have not tested this, is it possible to set pos, click a button and then set orientation ?. if it is possible, please make the necessary changes. if this is not possible(or it doesn't feel intuitive), what would you suggest as the alternative ?

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you submitting code that you have not tested?

@jgillick
Copy link
Copy Markdown
Owner

These require functional examples that converge.

@vybhav-ibr
Copy link
Copy Markdown
Author

the example i included does converge, but not very well, further tuning is required. could you help with the reward engineering ?. The main issue I am facing is that, when the command position is more than half a meter from the current position the robot just gives up and falls on the ground, I have tried increasing the timeout, increase the reward weight, increase sensitivity. But I couldn't get a satisfactory result,

https://github.com/user-attachments/assets/f3df1780-89f6-42e8-be6f-4921eb664e8c
The jitter you see in between the two successful targets is the repeated resets,

@vybhav-ibr vybhav-ibr requested a review from jgillick December 29, 2025 11:30
@jgillick
Copy link
Copy Markdown
Owner

jgillick commented Jan 4, 2026

the example i included does converge, but not very well

Are these new managers for actual environments/robots you're working with that do converge? If so, the example doesn't have to use the Go2 robot, and you can import a robot that you're working with as the example.

Both examples are for the position command, and neither seems to demonstrate the pose command. Have you verified that PoseCommandManager works?

Also, you copied the README files without updating their contents. Please stop blindly copying code without updating it for your usecase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants