Merged
Conversation
This is a bit non-obvious, but it makes some sense with the way indentation works. Text on the same line as the task marker can't start a block. It has to be paragraph text.
jgm
reviewed
Feb 13, 2025
jgm
reviewed
Feb 14, 2025
Comment on lines
+142
to
+146
| addNodeToStack $ | ||
| Node (defBlockData paraSpec){ | ||
| blockStartPos = [pos'] | ||
| , blockLines = [toks] } | ||
| [] |
Owner
There was a problem hiding this comment.
What happens if there are no tokens after the marker, or only spaces? Do we get an empty Para? Should that be avoided?
Contributor
Author
There was a problem hiding this comment.
There shouldn't be an empty para here. This code is part of a case statement that checks for that.
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of these are the same fixes as pulldown-cmark/pulldown-cmark#1017 (except the indentation bug in commonmark-hs, and the lone marker bug in pulldown-cmark)