Update bash completion options for --pdf-engine

[lodwicz]

Removed 'pdfroff' from the list of options for --pdf-engine, to avoid lookup for pdfroff.exe win executable on cygwin, and enable native cygwin script...

The alternative groff -Tpdf groff engine is not enumerated, and runs perfectly well on cygwin without searching for a Win executable.

[alerque]

This completion script affects all platforms, no? It seems like you're trying to solve a platform and environment specific problem with a change that will affect many other scenarios that might already work properly as collateral damage.

[lodwicz]

it seems to me that this bash completion is redundant, since appending the .exe extension affects only windows executables, and windows does not support bash (for pdfroff) completion: being a shell script, there is no direct executable required on *ix, or it should be provided separately for windows, the same as gropdf, the script for the alternative groff pdf-engine, which is a perl script. Again: either (both) should be provided with bat or exe stubs to run on windows.

[alerque]

What are you talking about? The code you removed isn't adding or using an exe extension in the first place.

[lodwicz]

my apologies: the issue is that pdfroff is no longer distributed with groff 1.24.x (discussed 2024-11-15; announced 28 feb 2026), so it could be removed; the executable extension appended came from older code.

the engine supported now by default by groff is the option -Tpdf as currently documented.

[jgm]

If we only had to support Windows, this change might make sense. But since there are other platforms that have pdfroff, it doesn't...

[lodwicz]

my apologies: the issue is that pdfroff is no longer distributed with groff 1.24.x (discussed 2024-11-15; announced 28 feb 2026), so it could be removed; the executable extension appended came from older code.

the engine supported now by default by groff is the option -Tpdf as currently documented.

perhaps the change should be to add the groff engine, which is now the supported engine by default by groff itself...

[jgm]

Good idea, I'll do that.