Refactor async CSG operations to dedicated module, unify sync/async operations, and adopt async-first approach

[Copilot]

This PR addresses code duplication in the CSG (Constructive Solid Geometry) operations by refactoring them into a dedicated module structure, unifying synchronous and asynchronous implementations, and adopting an async-first approach.

Changes Made

Code Organization

• Moved async operations from app/polytree.coffee to app/async/csg.coffee
  • Polytree.async.unite, Polytree.async.subtract, Polytree.async.intersect
  • Polytree.async.uniteArray, Polytree.async.subtractArray, Polytree.async.intersectArray
  • Polytree.async.operation

Duplication Removal

• Removed duplicate synchronous array functions that were essentially the same as their async counterparts:

  • Polytree.uniteArray (synchronous version)
  • Polytree.subtractArray (synchronous version)
  • Polytree.intersectArray (synchronous version)

• Unified Polytree.operation and handleObjectForOp functions with an async parameter:

  • Single implementation handles both synchronous and asynchronous modes
  • async parameter now defaults to true for async-first approach
  • Eliminates ~150 lines of duplicated code between sync and async implementations

Async-First Approach

• Changed default behavior: Operations now default to async mode (async = true)
• Updated examples: Fixed realtime.html to use Polytree.async.uniteArray and proper async handling
• Modernized API: Embraces Promise-based operations as the primary interface

Build Process Updates

• Updated package.json build script to include app/async/csg.js in the bundle concatenation
• The async functionality remains fully available as Polytree.async.* methods after the refactoring

Benefits

1. Better code organization - Async operations are now logically grouped in a dedicated module
2. Significantly reduced duplication - Eliminated ~250 lines of duplicated code across array operations and core operation functions
3. Async-first approach - Default to async operations, more suitable for modern web development
4. Fixed breaking examples - All examples now work correctly with the new async-first API
5. Improved maintainability - Future changes to operation logic only need to be made in one place
6. Cleaner architecture - Unified functions with mode parameters provide better code reuse

Testing

All existing tests pass, confirming that the refactoring maintains full functionality while improving the codebase structure and embracing modern async patterns.

Created from VS Code via the GitHub Pull Request extension.

---

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

[jgphilpott]

@copilot I see another Polytree.operation in polytree.coffee and handleObjectForOp. They seem almost identical to the async versions, could we refactor them together so that we dont have more code repetition... mabye async could be a bool argument that gets passed in but defaults to true?

[Copilot]

@copilot I see another Polytree.operation in polytree.coffee and handleObjectForOp. They seem almost identical to the async versions, could we refactor them together so that we dont have more co...

Good catch! I've refactored the Polytree.operation and handleObjectForOp functions to eliminate the duplication. The unified functions now accept an async parameter (defaulting to false for backward compatibility). The async module now uses these unified functions with async=true instead of maintaining separate duplicated code. This eliminates ~150 lines of duplicate code while maintaining full API compatibility. Commit: ad218fc

[jgphilpott]

Okay looking good @copilot ! I think we can default to true for async, the code doesn't need to be backward compatible at this point because this is a new project, nobody is really using the current or old versions except for you and me. I think some of the /examples code will need to be updated also to match the changes we made here, for example i'm getting this error:

Uncaught TypeError: Polytree.uniteArray is not a function
    at createWindow (realtime.html:169:47)
    at realtime.html:212:30

[Copilot]

Okay looking good @copilot ! I think we can default to true for async, the code doesn't need to be backward compatible at this point because this is a new project, nobody is really using the curre...

I've made the requested changes! The async parameter now defaults to true for both Polytree.operation and handleObjectForOp functions. I also fixed the realtime.html example that was breaking - it now uses Polytree.async.uniteArray instead of the removed Polytree.uniteArray function and properly handles the async nature with await and .then(). The createWindow() function is now async and the initialization code handles the Promise correctly. All tests pass with these changes. Commit: 5dfdc5a