Added size parameter, including all known large elePHPants #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
|
Fixed all conflicts |
cookieguru
reviewed
Feb 16, 2024
resources/data/elephpants.json
Outdated
| "image": "1-original-blue.jpg" | ||
| }, | ||
| { | ||
| "name": "Original Blue", |
There was a problem hiding this comment.
Should be resolved. Very odd behaviour...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a new pull request instead of changing the old one, since I had to reset a bunch of (seemingly unrecoverable) things in my Github account.
I added the size parameter, which defaults to 'small' but can be anything else in theory. If the parameter is not 'small', it is used to show behind the name of the elephpant type.
Logically a db migration is required.
One important note : I had to change the default order from "year desc, id desc" to "year desc, name asc" to make sure the small and large (or other) versions would be together. I don't think the id adds a lot of value, other than having a reverse order within a given year (which seems only useful for the last few models) ?