Fix #93: handle very long expirations without blocking others #95
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Using extremely large TTLs (e.g., Long.MAX_VALUE or values that saturate to it) can break expiration scheduling. The code computes
expectedExpiration = now + durationin nanoseconds. With a huge duration this overflows to a negative value, making that entry look like the earliest expiration. The scheduler then computesexpectedExpiration - now, which underflows to a massive positive delay (~292 years). Because ExpiringMap schedules one entry at a time, short TTL entries stop expiring.Fix
expectedExpirationto avoid overflow.Long.MAX_VALUEas "no expiration" and skip scheduling such entries.Tests