Enable async runAppFunction callbacks#205
Open
micimize wants to merge 1 commit intojhomlala:masterfrom
Open
Conversation
Use FutureOr<void> for runAppFunction and _runZonedGuarded callback return type, and pass runAppFunction! directly to _runZonedGuarded.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
FutureOr<void>forrunAppFunctionand_runZonedGuardedcallback return type,and pass
runAppFunction!directly to_runZonedGuarded.It seems that currently passing an async function to
runAppFunctionresults in some error state, likely due to not being awaited. I'm not if there are any setup actions that need to be in the same zone but it is more intuitive to add this flexibility if possible.I made this patch directly in the GitHub UI so I may have missed something.