FIX - updated c-code, previous version did not compile for me#1
Open
schoffelen wants to merge 4 commits intojiecui:masterfrom
Open
FIX - updated c-code, previous version did not compile for me#1schoffelen wants to merge 4 commits intojiecui:masterfrom
schoffelen wants to merge 4 commits intojiecui:masterfrom
Conversation
…x for option handling to accommodate older matlab versions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @jiecui, in order to get your efforts integrated into fieldtrip, I tried to compile the mex files on my end. I didn't succeed given the version of the code in your repo (for the v3 code). If I update the meflib.c code with the latest version from github, the compilation works fine. I suggest that you check whether this PR can be merged into your code base (i.e. whether the mex-file compilation still works fine on the operating systems on which you have been testing your code)
Also, I added a setup_mayo_mef.m script that does a little bit clever path setting (and checking whether te DHN distro exists somewhere on the path), followed by the setup of the mex files.