Skip to content

Changed select option in FBI search to Rails version#17

Open
olegkolyaka78 wants to merge 2 commits intojimenezmiguela:masterfrom
olegkolyaka78:selectOptionFBI
Open

Changed select option in FBI search to Rails version#17
olegkolyaka78 wants to merge 2 commits intojimenezmiguela:masterfrom
olegkolyaka78:selectOptionFBI

Conversation

@olegkolyaka78
Copy link
Collaborator

Issue Link: Changed select option in FBI search to Rails version #16

Description

Instead of JS version of selection option for FBI search I used Rails version
<%= label='Choose a Search Option :' %> <%= select_tag(:fbi_api_word, options_for_select([['all'], ['title'], ['description'], ['details'], ['sex'], ['race'], ['id'], ['hair color'], ['hair color'], ['weight'], ['classification'], ['url']]))%>
image

Type of Change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Maintenance or Refactor (non-breaking change which does not affect existing functionality)

Checklist

  • I tested my changes locally
  • I added tests to cover new functionality
  • All new and existing tests are passing (bundle exec rspec)
  • I updated my branch with master so that they can be merged easily

@olegkolyaka78 olegkolyaka78 linked an issue Mar 30, 2022 that may be closed by this pull request
Copy link
Collaborator

@inlibra-cpa inlibra-cpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello Oleg! This code looks reasonable to me. That's a hard work!

@jimenezmiguela
Copy link
Owner

Hi Oleg, what are the conflicts?

@olegkolyaka78
Copy link
Collaborator Author

Select Option conflicts with Input field "fbi_api_word":

<<<<<<< selectOptionFBI

<%= label='Choose a Search Option :' %> <%= select_tag(:fbi_api_word, options_for_select([['all'], ['title'], ['description'], ['details'], ['sex'], ['race'], ['id'], ['hair color'], ['weight'], ['classification'], ['url']]))%>
=======

master

Copy link
Collaborator

@inlibra-cpa inlibra-cpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good Oleg!

Copy link
Collaborator

@inlibra-cpa inlibra-cpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Oleg,
The code looks good to me)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Changed select option in FBI search to Rails version

3 participants