You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The yarn_integrity file should be added to you .gitignore list, I don't think that this is a file that we need checked into the main source code.
In the future, you might want to focus your testing efforts on the developer created logic and the core functionality of the application. Rails does a good job of testing it's methods like validates, presence, and belongs to. The tests included are useful, but not as useful as something that covers the developer created logic. Most of this lives in the controller, since this is an API. Consider adding request specs and it will cover a lot of these test cases for free!
Also, I am going to refrain from approving any PRs, so I would tag one of your classmates to get an approval.
The reason will be displayed to describe this comment to others. Learn more.
Ryan left our team, I'm approving his improvements.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run the following to see the new tests pass:
bundle exec rspec -fdThis PR is the result of