feat: add direct kv_module plugin support#70
Open
jimmy-claw wants to merge 18 commits intomainfrom
Open
Conversation
- CalendarStore now supports three modes: logos_host (QtRO), direct kv_module plugin, and in-memory fallback - Priority: logos_host > direct kv_module > memory - Added setKvModule(IKvModule*) method for direct plugin linkage - Updated CMakeLists.txt to detect and link kv_module when available - Added start-scala-with-kv.sh script to demonstrate standalone usage - Backwards compatible: existing logos_host mode still works - Allows Scala to run standalone with persistence without logos_host
…E_AVAILABLE Create src/i_kv_module.h as a pure virtual interface matching the KvModule API (set/get/remove/list/listAll/clear). Guard all IKvModule usage across calendar_store, calendar_module, and standalone/main.cpp with #ifdef KV_MODULE_AVAILABLE so CI builds cleanly without nix headers. Simplify CMakeLists.txt: since i_kv_module.h now lives in src/, KV_MODULE_AVAILABLE is always ON and no external header search is needed. The kv_module library link remains optional (runtime QPluginLoader). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See PR description: https://github.com/jimmy-claw/scala/blob/feature/direct-kv-module-support/DIRECT_KV_MODULE_PR.md