chore: clean up Makefile and CMakeLists.txt for logos-app path#76
Merged
jimmy-claw merged 4 commits intomainfrom Mar 13, 2026
Merged
chore: clean up Makefile and CMakeLists.txt for logos-app path#76jimmy-claw merged 4 commits intomainfrom
jimmy-claw merged 4 commits intomainfrom
Conversation
Lead with IComponent plugin approach (make build-ui-plugin, logos-app plugin directory). Document dependency chain, FileBackend persistence, nix ui-plugin output. Move standalone/make dev to legacy section. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…path Remove standalone build, run targets, CLI call targets, setup-logoscore, setup-kv-module, screenshot, and staging hack (run-app). Keep only the targets needed for the logos-app plugin workflow: build-ui-plugin, build-module, install, install-module, test, clean, and setup-nix-merged. Remove BUILD_STANDALONE option from CMakeLists.txt. Guard the default plugin target with if(NOT BUILD_MODULE) to avoid target name conflicts. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BUILD_STANDALONEoption and all standalone cmake code from CMakeLists.txtinstall(copies libscala_ui.so to logos-app plugins dir) andinstall-module(copies scala_module to logos-app modules dir) targetsif(NOT BUILD_MODULE)to fix cmake target name conflictbuild-ui-plugin,build-module,install,install-module,test,clean,setup-nix-mergedTest plan
make build-ui-pluginbuilds successfullymake build-modulebuilds successfully🤖 Generated with Claude Code