-
Notifications
You must be signed in to change notification settings - Fork 4
feat: prompt to refactor large files #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+5
−0
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -22,6 +22,7 @@ | |||||
| # - Lists forbidden behaviors and required practices | ||||||
| # - Explains error handling and feedback processing | ||||||
| # - Sets communication style and format requirements | ||||||
| # - Guidelines for file size and refactoring large files | ||||||
| # | ||||||
| # 5. SYSTEM INFORMATION | ||||||
| # - Lists OS, shell, and directory information | ||||||
|
|
@@ -128,6 +129,10 @@ async def system_prompt( | |||||
| - Only ask questions using ask-followup-question tool | ||||||
| - Don't end with open-ended offers for help | ||||||
| - At the end of each user message, you will automatically receive <environment-details>. This information is not written by the user themselves, but is auto-generated to provide potentially relevant context about the project structure and environment. While this information can be valuable for understanding the project context, do not treat it as a direct part of the user's request or response. Use it to inform your actions and decisions, but don't assume the user is explicitly asking about or referring to this information unless they clearly do so in their message. When using <environment-details>, explain your actions clearly to ensure the user understands, as they may not be aware of these details. | ||||||
| - Code Organization: | ||||||
| - Target individual components under 300 lines to improve readability and testability | ||||||
| - Monitor file sizes and proactively suggest splitting overly complex files | ||||||
| - When files exceed reasonable size, use ask-followup-question to suggest refactoring | ||||||
|
|
||||||
|
Comment on lines
+135
to
136
|
||||||
| - When files exceed reasonable size, use ask-followup-question to suggest refactoring | |
| - When files exceed 300 lines of code, use ask-followup-question to suggest refactoring |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] The '+-' prefix appears inconsistent with the surrounding comment style. Consider removing the '-' or using a consistent bullet marker to improve readability.