Skip to content

feat: add escaping strategy for JSON #1077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: add escaping strategy for JSON #1077

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions handlebars/src/main/java/com/github/jknack/handlebars/EscapingStrategy.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,10 @@ private static Map<CharSequence, CharSequence> escapeMap(final String[][] table)
EscapingStrategy JS = value ->
value == null ? null : StringEscapeUtils.escapeEcmaScript(value.toString());

/** Escape variable for JSON. */
EscapingStrategy JSON = value ->
value == null ? null : StringEscapeUtils.escapeJson(value.toString());

/** NOOP escaping. */
EscapingStrategy NOOP = value -> value;

Expand Down
18 changes: 18 additions & 0 deletions handlebars/src/test/java/com/github/jknack/handlebars/EscapingStrategyTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
package com.github.jknack.handlebars;

import org.junit.Test;

import java.io.IOException;

import static org.junit.Assert.assertEquals;

public class EscapingStrategyTest {
@Test
public void shouldEscapeVariableForJSON() throws IOException {
Template template = new Handlebars().with(EscapingStrategy.JSON).compileInline("{{this}}");

assertEquals("\\\"", template.apply("\""));
assertEquals("\\\\", template.apply("\\"));
assertEquals("\\/", template.apply("/"));
}
}