Fix for parsing broken processing instructions#1
Open
jkoops wants to merge 5 commits intof4b25b7a6ffrom
Open
Conversation
Some HTML contains broken processing instructions, such as this one encountered in the wild: `<?xml:namespace prefix = o ns = "urn:schemas-microsoft-com:office:office" />`. The parser crashes on this since it only accepts `?>` (or end-of-file) as the end of a processing instruction. This patch fixes it by also allowing `>` or `/>` to end a processing instruction.
Some HTML contains broken processing instructions, such as this one encountered in the wild: `<?xml:namespace prefix = o ns = "urn:schemas-microsoft-com:office:office" />`. The parser crashes on this since it only accepts `?>` (or end-of-file) as the end of a processing instruction. This patch fixes it by also allowing `>` or `/>` to end a processing instruction.
When the HTML parser attempts to parse tags that should be
singletons but are not, AND they have content, an exception
occurs:
1> mochiweb_html:parse("<html><input><input>x</input></input></html>").
** exception error: no case clause matching
{[],[{<<"input">>,[],[<<"x">>]},{<<"input">>,[],[]}]}
in function mochiweb_html:destack/2
in call from mochiweb_html:tree/2
in call from mochiweb_html:parse_tokens/1
This patch provides a fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some HTML contains broken processing instructions, such as this one encountered in the wild:
<?xml:namespace prefix = o ns = "urn:schemas-microsoft-com:office:office" />.The parser crashes on this since it only accepts
?>(or end-of-file) as the end of a processing instruction. This patch fixes it by also allowing>or/>to end a processing instruction.