Skip to content

Make momgrid failures optional exceptions #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jkrasting merged 1 commit into from
Sep 5, 2025
Merged

Make momgrid failures optional exceptions #54

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/esnb/sites/gfdl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,7 +275,7 @@ def call_dmget(files, status=False, verbose=True):
_ = subprocess.check_output(cmd)


def convert_to_momgrid(diag, positive_longitudes=False):
def convert_to_momgrid(diag, positive_longitudes=False, fatal_on_error=True):
import momgrid

for n, ds in enumerate(diag._datasets):
Expand All @@ -292,8 +292,9 @@ def convert_to_momgrid(diag, positive_longitudes=False):
logger.debug(f"Replacing existing dataset [{n}] with momgrid version")
ds.replace(_ds.data)
except Exception as exc:
logger.debug(f"Unable to convert dataset [{n}] with momgrid")
raise exc
logger.warning(f"Unable to convert dataset [{n}] with momgrid: {exc}")
if fatal_on_error:
raise exc


def load_dora_catalog(idnum, **kwargs):
Expand Down